Add preliminary powertrain model - #25
Draft
Tacocat0254 wants to merge 1 commit into
Draft
Tacocat0254 wants to merge 1 commit into
Tacocat0254 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a preliminary powertrain model with an optional torque-versus-rpm cap, a speed-scheduled multi-ratio transmission with shift hysteresis, and live transmission-ratio feedback for VCU torque conversion. Wire the motor and transmission parameters into the vehicle/FMI templates and include the generated vehicle-record changes.
How to check
Whitespace checks pass in both repositories; all four changed Python modules parse successfully. Full validation is blocked locally: Docker and OpenModelica are unavailable, Ruff is missing, and the installed pandas extension has an incompatible CPU architecture. Attempts at
make ci,make regression-baseline, andmake opt-doe-smokecould not complete. No regression baselines were updated.Notes
Draft pending Modelica compilation, shift-event validation, and full vehicle regression. The transmission assumes complete reduction in gearRatios and unity downstream final drive. Review single-gear and end-gear scheduler indexing, instantaneous ratio transitions, and generated-record consistency before merging. Rebased onto current main while retaining upstream reverse-launch support.
Companion BobSim integration: BobDyn/BobSim#69