Repository navigation
Make PyramidContents immutable, except for pixel data - #154
Merged
Merged
Conversation
stefanhahmann
force-pushed
the
issue-114-immutable-pyramid-contents
branch
from
October 26, 2026 13:41
605c812 to
ca49d30
Compare
stefanhahmann
force-pushed
the
issue-114-immutable-pyramid-contents
branch
from
October 26, 2026 14:25
ca49d30 to
603feaa
Compare
Both were public fields. They are now private behind name() and hasPlaceholderCalibration(). Neither was mutable, but the remaining fields will get accessors for issue #114, and the API should be uniform. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Its public fields let any opener change the cached contents (#114). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
stefanhahmann
force-pushed
the
issue-114-immutable-pyramid-contents
branch
from
October 27, 2026 13:07
603feaa to
0caf669
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114.
OmeZarrcaches onePyramidContentsfor all openers, so a caller that changed a transform or the OMERO metadata changed every later display.Images stay shared, not copied. Copying a lazy
CachedCellImgwould read the whole dataset, and ImageJ edits showing up in BDV may even be considered a feature, cf. (#148).Breaking API changes
ome-zarr-imglib2PyramidContents: public fields replaced by accessorsname,type,omero,hasPlaceholderCalibration→name(),type()(a new instance per call),omero(),hasPlaceholderCalibration()transforms[ level ]→transform( level )(a copy)axesPerLevel[ level ]→axes( level )(an unmodifiableList)cachedCellImgs[ level ]→asImg( level )Omeroand its nestedRdefs,ChannelandWindoware final: public fields replaced by constructors and accessors, e.g.omero.channels()(unmodifiable),channel.window().start()ome-zarr-n5,ome-zarr-zarrjava,ome-zarr-fiji,ome-zarr-fiji-uiNo API changes.
🤖 Generated with Claude Code