Add Xiaomi Installation - #259
Open
weihengSu2 wants to merge 2 commits into
Open
Conversation
added 2 commits
March 7, 2023 11:43
Member
|
Have these changes been tested with the following method to see if a valid request is generated? Bonus points if it's actually worked against our backend. |
Author
Yes I will do the actual integration tests today including this one. And thanks very much for the review too! 🙂 |
3 tasks
Merged
Matthew Podwysocki (mpodwysocki)
added a commit
to Azure/azure-sdk-for-js
that referenced
this pull request
Mar 9, 2023
### Packages impacted by this PR - @azure/notification-hubs ### Issues associated with this PR ### Describe the problem that is addressed by this PR Adds Xiaomi support for Track 2 SDKs with registration, installation, send and send outcome operations. ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? ### Are there test cases added in this PR? _(If not, why?)_ yes ### Provide a list of related PRs _(if any)_ - Azure/azure-notificationhubs-dotnet#261 - Azure/azure-notificationhubs-dotnet#260 - Azure/azure-notificationhubs-dotnet#259 ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ ### Checklists - [x] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [x] Added a changelog (if necessary) --------- Co-authored-by: Jeremy Meng <jeremy.ymeng@gmail.com>
Jessica Huh (jessHuh)
self-requested a review
March 9, 2023 23:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things to consider before you submit the PR:
Description
Add Xiaomi Installation classes