[notification hubs] Adding Xiaomi support - #25171
Merged
Merged
Conversation
Matthew Podwysocki (mpodwysocki)
requested review from
Brian Terlson (bterlson),
Jeremy Meng (jeremymeng) and
Jeff Fisher (xirzec)
as code owners
March 8, 2023 18:50
Collaborator
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
Jeremy Meng (jeremymeng)
approved these changes
Mar 8, 2023
Jeremy Meng (jeremymeng)
left a comment
Jeremy Meng (jeremymeng)
left a comment
Member
There was a problem hiding this comment.
LGTM except the version
Matthew Podwysocki (mpodwysocki)
requested review from
Albert Cheng (ckairen),
Deyaa (deyaaeldeen) and
Mike Harder (mikeharder)
as code owners
March 9, 2023 18:27
Co-authored-by: Jeremy Meng <jeremy.ymeng@gmail.com>
Matthew Podwysocki (mpodwysocki)
enabled auto-merge (squash)
March 9, 2023 22:32
Contributor
Author
|
/check-enforcer evaluate |
Contributor
Author
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
Issues associated with this PR
Describe the problem that is addressed by this PR
Adds Xiaomi support for Track 2 SDKs with registration, installation, send and send outcome operations.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
yes
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists