Skip to content

Features/setup ci #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Arrat3 merged 2 commits into from
Mar 7, 2026
Merged

Features/setup ci #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16cbfed
Add CI workflow with lint and tests
Arrat3 Mar 6, 2026
23fc2ae
Modify ci.yml's location
Arrat3 Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: CI

on:
pull_request:
branches: [main]

jobs:
build:
runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 20

- name: Install dependencies
run: npm ci

- name: Run lint
run: npm run lint

- name: Run tests
run: npm test
9 changes: 9 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
import js from "@eslint/js";
import globals from "globals";
import tseslint from "typescript-eslint";
import { defineConfig } from "eslint/config";

export default defineConfig([
{ files: ["**/*.{js,mjs,cjs,ts,mts,cts}"], plugins: { js }, extends: ["js/recommended"], languageOptions: { globals: globals.browser } },

@MahmoudH96 MahmoudH96 Mar 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: why did you extends "js/recomended" while using tseslint.configs.recommended ?

@Arrat3 Arrat3 Mar 7, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included "js/recomended" to provide the base linting rules for JS.
Since "tselint.configs.recomended" is designed to work alongside those base rules.

should i be satisfied with "tselint.configs.recomended" ?

@MahmoudH96 MahmoudH96 Mar 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess for the future you can use the following code from their docs:

export default defineConfig(
.......
  eslint.configs.recommended,
  tseslint.configs.recommended,
);

instead of extends: ["js/recommened"]
Which is cleaner
but not sure if it's going to work or you need to update other parts as well

tseslint.configs.recommended,
]);
Loading