Features/setup ci - #3
Merged
Merged
Conversation
MahmoudH96
reviewed
Mar 7, 2026
|
|
||
| for (let char of input) { | ||
| let isAllowedChar: boolean = | ||
| for (const char of input) { |
MahmoudH96
reviewed
Mar 7, 2026
| import { defineConfig } from "eslint/config"; | ||
|
|
||
| export default defineConfig([ | ||
| { files: ["**/*.{js,mjs,cjs,ts,mts,cts}"], plugins: { js }, extends: ["js/recommended"], languageOptions: { globals: globals.browser } }, |
Collaborator
There was a problem hiding this comment.
question: why did you extends "js/recomended" while using tseslint.configs.recommended ?
Owner
Author
There was a problem hiding this comment.
I included "js/recomended" to provide the base linting rules for JS.
Since "tselint.configs.recomended" is designed to work alongside those base rules.
should i be satisfied with "tselint.configs.recomended" ?
Collaborator
There was a problem hiding this comment.
I guess for the future you can use the following code from their docs:
export default defineConfig(
.......
eslint.configs.recommended,
tseslint.configs.recommended,
);
instead of extends: ["js/recommened"]
Which is cleaner
but not sure if it's going to work or you need to update other parts as well
MahmoudH96
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.