Repository navigation
Reduce Apple chart rendering work with vectorized plots - #19
Closed
AlexSchmidt1999 wants to merge 1 commit into
Closed
AlexSchmidt1999 wants to merge 1 commit into
AlexSchmidt1999 wants to merge 1 commit into
Conversation
Owner
Author
|
Closing this older fork test PR. Its full head ( The relevant changes are now submitted for upstream review in #2762. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today and Trends build a line and area mark for every plotted point. Use Apple's vectorized LinePlot/AreaPlot for the same collections on iOS 18+ and macOS 15+, preserving the existing mark path on older systems. Samples, segment boundaries, scales, gradients, annotations, selection, zoom and accessibility remain in place; bars are unchanged.
Validation: both Apple app targets compile; 133 design tests pass (one existing English-only word test excluded on the German host). Eleven native comparisons against the previous production charts preserve rendering, including gaps and HR annotations. Local synthetic chart render medians fall from 6.39 to 4.85 ms (288-point Trends) and 6.38 to 4.67 ms (288-point Overview HR). These are macOS rendering measurements, not an iPhone scroll benchmark. Details and limits are in docs/FORK_CHART_PERFORMANCE.md. Raw device traces remain local.
Fork-only testing; no upstream PR or release. Apple-only as requested.