Repository navigation
Defer dashboard chart layout and retain Trends calendar data - #20
Closed
AlexSchmidt1999 wants to merge 3 commits into
Closed
AlexSchmidt1999 wants to merge 3 commits into
AlexSchmidt1999 wants to merge 3 commits into
Conversation
Owner
Author
|
Closing this older fork test PR. Its full head ( The relevant changes are now submitted for upstream review in #2638, #2764. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today and Trends passed one eager inner card column to their lazy screen scaffold, so entering the screen still laid out the whole card list. Use native LazyVStack for both inner columns, keeping existing content, spacing, section order and gestures. Reuse Trends' existing generation/range/day/locale cache for calendar dates, and retain date-based calendar identities across redraws. Performance-capture start lines now include the installed version/build for future comparisons.
Validation: combined Release iOS app/widgets/watch build and macOS build pass; 31 targeted app tests pass; 133 design tests pass, excluding one pre-existing English-only word expectation on this German host. A reduced native macOS probe lays out 3 rather than 14 cards initially, and materializes more when scrolling. Source, binary (four bundles), localization and doc-comment checks pass. No dependency, background watcher or new user setting.
Build 447 includes this change and the stacked native-chart PR #19. It is installed and launched on the owner's iPhone; a fresh local archive confirms captureStart version=12.0.0 build=447. Local ordinary-use captures contain about 37.5 sampled minutes on Today and 4.3 on Trends and confirm intermittent callback stalls. Their build version was not recorded, so they are not a controlled before/after comparison. Repeat iPhone scrolling is still needed before claiming smooth device performance. Details and privacy boundaries are in docs/FORK_PERFORMANCE_TESTING.md; raw data remains local.
Fork-only test version. Android is outside the requested scope. No upstream PR, release, or resumed build automation.