Repository navigation
Add dotcl-bin to the implementation check - #41
Merged
Merged
Conversation
Member
|
Thank you! |
Contributor
Author
|
Thank you for merging! Do you plan to make a new release? I want to use this from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Roswell v26.10.117 and later can install dotcl
(a Common Lisp implementation on .NET) as
dotcl-bin. With this action,everything up to the last step already works; only the final check in
test.rosfails becausedotcl-binis not in its table. This PR adds the entry.Usage:
and
LISP: dotcl-binin the environment. dotcl needs .NET 10, which ispreinstalled on GitHub's
ubuntu-latestrunners.I left the default
roswell-versionalone. Two things changed inv26.10.118 that may matter if you decide to bump it later:
scripts/install-for-ci.shof a release tag now installs that same release(before, a tag's script pointed at the previous one).
(x86_64, arm64, riscv64, loongarch64) instead of only x86_64, and falls back
to building from source when there is no binary.
Tested on
ubuntu-latestwithroswell-version: v26.10.118inhttps://github.com/dotcl/xmls/actions/runs/38234272709 —
dotcl-bin,sbcl-bin,ccl-bin/1.12.2,ecl,cmu-bin/21e,clisp/2.49,clisp-headand
abcl-bin/1.9.2all pass.Not working on macOS yet: there the action installs Roswell from Homebrew
regardless of
roswell-version, and the currentmacos-latestimage stillresolves the formula to 26.02.116, which does not know
dotcl-bin(themacos-latest/dotcl-binjob in the run above fails for this reason).It should start working once the runner image picks up a newer formula.
I did not touch the test matrix or the implementation table in the README,
since they look generated.