Skip to content

Support dotcl in the test op - #20

Merged
rpgoldman merged 2 commits into
rpgoldman:masterfrom
dotcl:dotcl
Oct 15, 2026
Merged

rpgoldman merged 2 commits into
rpgoldman:masterfrom
dotcl:dotcl

Conversation

@snmsts

@snmsts snmsts commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

dotcl (https://github.com/dotcl/dotcl) is a Common Lisp implementation on
.NET. XMLS itself already works on dotcl; only the test op refused to run
("Test OP for XMLS not supported on this lisp implementation.").

This adds dotcl to the implementations that define TEST and run
xmls/test, and reads the test files given on the command line after "--"
from dotcl:command-line-arguments, as for SBCL and CMUCL.

(asdf:test-system "xmls") passes on dotcl 0.1.32 and on SBCL 2.6.8: all 35
files parse with both PARSE and PARSE-TO-LIST, and xmls/unit-test passes 36
of 36.

Add dotcl to the implementations that define TEST and run the xmls/test
op, and read its command-line arguments after "--" with
dotcl:command-line-arguments, as for SBCL and CMUCL.
@rpgoldman

Copy link
Copy Markdown
Owner

Probably we should add dotcl to the tests -- it looks like dotcl and dotcl-bin are both roswell-installable. Do you know which I should use for testing?

@snmsts

snmsts commented Oct 9, 2026

Copy link
Copy Markdown
Contributor Author

Ah. dotcl is supported on roswell but it is not released yet. I'll release it first. I'll do release and test then report in a few days about how it should be.

@rpgoldman

Copy link
Copy Markdown
Owner

OK. As soon as I hear from you, I will update the CI for dotcl and merge. Thanks for the patch!

@snmsts

snmsts commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

Sorry for the delay. Roswell v26.10.118 is released and it supports dotcl-bin.

Please use dotcl-bin for testing. It is the only one Roswell can install
(ros install dotcl does not work).

I pushed a commit that updates the CI in this PR:

  • add dotcl-bin
  • Roswell v22.12.14.113 -> v26.10.118
  • abcl/1.9.2 -> abcl-bin/1.9.2 (in the new Roswell, abcl means building from source)
  • 40ants/setup-lisp@v2 -> the commit that supports dotcl-bin.
    It is merged (Add dotcl-bin to the implementation check 40ants/setup-lisp#41) but there is no release tag yet,
    so I use the commit hash for now.

Please change them as you like.

@rpgoldman
rpgoldman merged commit b012b5a into rpgoldman:master Oct 15, 2026
8 checks passed
@rpgoldman

Copy link
Copy Markdown
Owner

Done! Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants