Repository navigation
Support dotcl in the test op - #20
Merged
Merged
Conversation
Add dotcl to the implementations that define TEST and run the xmls/test op, and read its command-line arguments after "--" with dotcl:command-line-arguments, as for SBCL and CMUCL.
Owner
|
Probably we should add dotcl to the tests -- it looks like dotcl and dotcl-bin are both roswell-installable. Do you know which I should use for testing? |
Contributor
Author
|
Ah. dotcl is supported on roswell but it is not released yet. I'll release it first. I'll do release and test then report in a few days about how it should be. |
Owner
|
OK. As soon as I hear from you, I will update the CI for dotcl and merge. Thanks for the patch! |
Contributor
Author
|
Sorry for the delay. Roswell v26.10.118 is released and it supports dotcl-bin. Please use I pushed a commit that updates the CI in this PR:
Please change them as you like. |
Owner
|
Done! Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotcl (https://github.com/dotcl/dotcl) is a Common Lisp implementation on
.NET. XMLS itself already works on dotcl; only the test op refused to run
("Test OP for XMLS not supported on this lisp implementation.").
This adds dotcl to the implementations that define TEST and run
xmls/test, and reads the test files given on the command line after "--"
from dotcl:command-line-arguments, as for SBCL and CMUCL.
(asdf:test-system "xmls") passes on dotcl 0.1.32 and on SBCL 2.6.8: all 35
files parse with both PARSE and PARSE-TO-LIST, and xmls/unit-test passes 36
of 36.