-
Notifications
You must be signed in to change notification settings - Fork 4
Bun/JSC JIT symbol resolution via JITDump #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4af3f2e
Bun/JSC JIT symbol resolution via JITDump (rebased from bun branch)
zz85 52078c7
jitdump: address review — MOVE layout, LOAD bounds, mutation flush, o…
zz85 5c8c6fd
jitdump: round-2 review — bounds, retryable reload, header-pid check,…
zz85 bbdd76a
jitdump: use repeat_n in test helper (clippy manual_repeat_n)
zz85 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
Repository: zz85/profile-bee
Length of output: 20743
🏁 Script executed:
Repository: zz85/profile-bee
Length of output: 37677
🏁 Script executed:
Repository: zz85/profile-bee
Length of output: 32319
Invalidate cached frames after every JITDump table mutation.
parse_code_movereplaces a symbol without changingsymbols.len().reload_from_filecan therefore returnOk(0), andreload_jitdump_tablescan serve stale cached frames for that PID. Return a mutation indicator and flush the cache when it is true.🤖 Prompt for AI Agents