Repository navigation
Conversation
Contributor
Author
There was a problem hiding this comment.
Pull request overview
Adds initial ReScript bindings for Bun’s bun:ffi module (FFI^2) and introduces accompanying FFI-focused tests plus small C fixtures to validate dlopen, typed pointers, and cc compilation.
Changes:
- Add
src/FFI.resbindings forbun:ffi(dlopen/linkSymbols, pointers, CString/JSCallback/CFunction,cc, viewSource, read helpers). - Add a new FFI test suite and small C sources used by the tests.
- Add a precompiled
test/ffi_testlib.soartifact fordlopen-based tests (plusbun.lock).
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/ffi_testlib.so | Adds a precompiled shared library used for dlopen tests. |
| test/ffi_testlib.c | C fixture implementing simple functions (add/multiply/etc.) for FFI tests. |
| test/ffi_square.c | C fixture for validating CC.compile from a file. |
| test/FFITest.res | ReScript FFI test suite exercising suffix/dlopen/cstring/pointers/read/cc. |
| test/FFITest.js | Generated JS output for the ReScript FFI test suite. |
| src/FFI.res | New bun:ffi bindings for ReScript, including Read, CString, JSCallback, and CC. |
| src/FFI.js | Generated JS output for the new FFI bindings module. |
| bun.lock | Adds a Bun lockfile snapshot. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@fabrv I think the remarks are on point, can you take a look. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@nojaf Comments resolved. Please take another look. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bun's C ABI FFI bindings (FFI^2)