Skip to content

Restore two changes lost to a squash merge - #1166

Merged
dyve merged 1 commit into
mainfrom
restore-lost-sync-commits
Oct 11, 2026
Merged

dyve merged 1 commit into
mainfrom
restore-lost-sync-commits

Conversation

@dyve

@dyve dyve commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

Both of these were pushed to the sync-release-preflight branch after #1165 had already squash-merged, so they never reached main. Spotted by the django-bootstrap3 session, and the mistake was mine: I pushed to a branch whose pull request was closed, then polled CI and read that merged pull request's green checks as confirmation the new commits had landed. They had not. A green check on a merged PR says nothing about a commit pushed afterwards.

The 3.15 wording, and this is the one that matters before 26.3 is cut. The entry calls Python 3.15 a release candidate. 3.15.0 shipped on 2026-10-09, so that is no longer true, and here the entry is still in Unreleased where it can be fixed. django-icons and django-bootstrap4 both published that sentence already; their dated sections stay as they are, because a release section records what was said at the time rather than what turned out to be true.

The MAINTAINING.md note, propagated from zostera/django-marina#696: release-check reporting no Unreleased entries straight after a cut means nothing is pending, not that the changelog was lost. The paragraph is byte-identical to marina's.

Blast radius, since the same push pattern hit three repos: django-icons lost the same MAINTAINING note and gets its own restore. django-bootstrap5 is unaffected, because its sync pull request is still open and carries both commits. django-marina and django-bootstrap4 were never affected.

Nothing else from marina is outstanding for this repository after this.

🤖 Generated with Claude Code

Correction: an earlier revision of this description dated Python 3.15.0 to 2026-10-01. That is Python 3.10's end-of-life date. 3.15.0 released on 2026-10-09. Caught by the django-bootstrap5 session; no repository file or commit message carried the wrong date.

Both were pushed to the sync-release-preflight branch after #1165 had already
squash-merged, so they never reached main. My mistake: I pushed to a branch
whose pull request was closed, and the green checks I then polled were that
merged pull request's, which read as confirmation that the new commits had
landed. They had not.

The 3.15 entry no longer calls a released Python a release candidate. This one
matters before 26.3 is cut, because the entry is still in Unreleased here,
where it can be fixed. django-icons and django-bootstrap4 both published that
sentence; their dated sections stay as they are, since a release section
records what was said at the time.

MAINTAINING.md gains the note that release-check reporting no Unreleased
entries straight after a cut means nothing is pending, not that the changelog
was lost.

django-icons lost the same MAINTAINING note the same way and gets its own
restore. django-bootstrap5 is unaffected, its sync pull request is still open
and carries both commits.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@dyve
dyve merged commit 4051880 into main Oct 11, 2026
22 checks passed
@dyve
dyve deleted the restore-lost-sync-commits branch October 11, 2026 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant