Code quality - #1
Merged
Merged
Conversation
added 10 commits
June 12, 2026 15:46
…nd settings models for concurrency safety
…ent in IconCacheManager
- Added support for secure request handling between Finder extension and main application using a temporary plist file. - Implemented a new request structure to encapsulate actions and file transfers, ensuring safe communication. - Updated URL scheme handling to reject direct parameter passing for sensitive data. - Introduced AppleScript path encoding to prevent syntax alteration. - Added unit tests for secure request lifecycle, including validation of permissions and path formats. - Improved error handling and logging for better debugging and user feedback.
- Updated `FileTransferService` to manage file transfer tasks with improved lifecycle handling. - Introduced `FileTransferOperations` for handling file copying with progress tracking and cancellation support. - Added `FileTransferProgressWindow` to display real-time transfer progress and allow cancellation. - Modified `FileCreator` to accept a bundle parameter for file creation, ensuring correct template file access. - Enhanced unit tests for file creation and transfer operations, covering progress reporting, cancellation, and error handling. - Updated documentation to reflect changes in file transfer functionality and testing procedures.
…monitoring - Replaced manual file descriptor management in SettingsMonitor with DirectoryChangeMonitor for improved readability and maintainability. - Updated the logic for handling settings changes and invalidating cached configurations. - Added new tests for file transfer cancellation and partial failure scenarios in BetterMenuCoreServiceTests. - Introduced BetterMenuSecureRequest for secure communication between Finder extension and main app, ensuring safe request handling. - Implemented code style checks and formatting using swift-format, enforcing consistent code style across the project. - Updated build_and_run.sh script to support incremental builds and added commands for code formatting and linting. - Documented changes in DEVELOPMENT.md and README.md to reflect new features and guidelines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.