Split the room gfx tables from the bank20 code, and various other tweaks to easier mod the disasm - #631
Open
daid wants to merge 8 commits into
Open
Split the room gfx tables from the bank20 code, and various other tweaks to easier mod the disasm#631daid wants to merge 8 commits into
daid wants to merge 8 commits into
Conversation
…rtant to properly setup when editing rooms, and you likely want to edit them when modding.
…ct attribute file.
… This makes it clearer that this is happening and easier for modding.
daid
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tables are important to properly setup when editing rooms, and you likely want to edit them when modding.
As I'm working towards getting my room editor to work with the disassembly, this is another important set of tables that it would need to edit. So it for that reason I'm splitting them off from the code. But in general it's good to have tables split from the code anyhow.