Repository navigation
feat: Outer nullifier oprf_pk_hash binding - #169
Merged
Merged
Conversation
saleel
reviewed
Oct 19, 2026
Comment on lines
+137
to
+142
| // oprf_pk_hash is only meaningful for salted nullifiers (it is the OPRF service key | ||
| // hash). A non-salted subproof emits oprf_pk_hash = 0, which rides the per-subproof | ||
| // "== 0" wildcard below, leaving the top-level value otherwise unconstrained. Pin it: | ||
| // the top-level oprf_pk_hash must be zero unless the nullifier is salted, so a | ||
| // non-salted proof cannot publish a forged OPRF service hash. | ||
| assert( |
saleel
approved these changes
Oct 19, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes a residual gap in the outer aggregator: the top level
oprf_pk_hashwas unconstrained for non salted nullifiers.