Repository navigation
feat: FaceMatch Android app-id structural parse - #166
Merged
Merged
Conversation
saleel
approved these changes
Oct 19, 2026
Comment on lines
+132
to
+140
| // NOTE: like the pre-hardening `get_app_id_from_credential_tbs`, this still uses the | ||
| // non-strict `find_subarray_index` plus a flat forward scan, so the BF 85 3E key-origin | ||
| // tag is searched over a window that includes the attacker-controlled | ||
| // attestationChallenge. It is NOT currently exploitable because no circuit `main` calls | ||
| // this function (the `// TODO: Only accept GENERATED` in android/constants.nr is unwired), | ||
| // and any use would additionally be gated by the app-id / Play-Integrity path. If this | ||
| // is ever wired into an acceptance path, harden it the same way as `get_app_id`: strict | ||
| // OID anchor + structural walk into softwareEnforced/teeEnforced (skip attestationChallenge | ||
| // and uniqueId by length) before searching for the tag. |
Collaborator
There was a problem hiding this comment.
We should remove long comments like this unless they are actually required to explain a complex code below. All self explanatory code should not need any comments
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens the Android Keystore attestation parser so the
attestationApplicationIdis read from a structurally located position rather than a hinted forward scan.enter_element/skip_elementDER helpers.pub mod tests;and added real-fixture coverage.