Repository navigation
feat: TBS-pubkey DER structural binding - #165
Merged
Merged
Conversation
saleel
approved these changes
Oct 19, 2026
saleel
left a comment
Collaborator
There was a problem hiding this comment.
Can also remove long comments where not absolutely requried
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the TBS public-key extraction bind to the DER structure of
SubjectPublicKeyInforather than to fixed byte offsets, so it parses the encoding diversity present in real Document Signer Certificates.rsaEncryptionOID element, then skip an optional NULL before the BIT STRING.namedCurve(tag 06) and explicit params (tag 30).utils::read_der_length