Repository navigation
ci(packs): a release that refreezes nothing keeps the last library's packs - #36
Merged
Merged
Conversation
…packs The release-time freeze minted the crate's version into the library, so a release changing no circuit (v0.8.3: the crate on crates.io) failed the packs job's clean-tree check and left its release a draft. When the manifest's library version isn't the tag's, the circuits are that library's, whose packs are already published: the job skips building them and points the notes there.
Contributor
Code coverage76.12% of lines covered.
8 file(s) below 90% line coverage
7 further file(s) not shown. Reported, not enforced. Out-of-process suites (devnet e2e, testcontainers) do not appear in these numbers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What went wrong. The v0.8.3 release (the crate going to crates.io) changed no circuit, so the manifest is still frozen as
eid-circuits@0.8.2. The packs job's freeze minted 0.8.3 into the library, itsgit diff --exit-codecheck failed, and the release stayed a draft. The crate itself was published.The fix. The packs job first compares the manifest's
[library]version with the tag.After merging. Re-release v0.8.3 with
gh workflow run ci.yml -f tag=v0.8.3. The crate step skips (0.8.3 is already published), the packs job links v0.8.2's packs, and the draft is published.