Skip to content

ci(packs): a release that refreezes nothing keeps the last library's packs - #36

Merged
tonyvelichko merged 1 commit into
mainfrom
ci/packs-unchanged-circuits
Oct 1, 2026
Merged

tonyvelichko merged 1 commit into
mainfrom
ci/packs-unchanged-circuits

Conversation

@tonyvelichko

Copy link
Copy Markdown
Contributor

What went wrong. The v0.8.3 release (the crate going to crates.io) changed no circuit, so the manifest is still frozen as eid-circuits@0.8.2. The packs job's freeze minted 0.8.3 into the library, its git diff --exit-code check failed, and the release stayed a draft. The crate itself was published.

The fix. The packs job first compares the manifest's [library] version with the tag.

  • When they match, the release refroze the circuits, and the job builds and publishes the packs as before.
  • When they differ, the circuits are that library's, and its packs are already published. The job skips building them and points the release notes at that release.

After merging. Re-release v0.8.3 with gh workflow run ci.yml -f tag=v0.8.3. The crate step skips (0.8.3 is already published), the packs job links v0.8.2's packs, and the draft is published.

…packs

The release-time freeze minted the crate's version into the library, so a
release changing no circuit (v0.8.3: the crate on crates.io) failed the packs
job's clean-tree check and left its release a draft. When the manifest's
library version isn't the tag's, the circuits are that library's, whose packs
are already published: the job skips building them and points the notes there.
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Code coverage

76.12% of lines covered.

Metric Covered Total Coverage
Lines 2,120 2,785 76.12% ████████░░
Functions 209 272 76.84% ████████░░
Regions 4,120 5,520 74.64% ███████░░░
Branches — — — not instrumented
8 file(s) below 90% line coverage
File Lines Covered Functions
rust/eid-vectors/src/documents.rs 0.00% 0/96 0.00% ░░░░░░░░░░
rust/eid-vectors/src/steps.rs 34.25% 75/219 46.15% ███░░░░░░░
rust/eid-vectors/src/main.rs 66.75% 269/403 54.29% ███████░░░
rust/eid-vectors/src/mock.rs 74.10% 392/529 81.25% ███████░░░
rust/eid-prover/src/select.rs 81.65% 89/109 50.00% ████████░░
rust/eid-vectors/src/circuits.rs 84.86% 325/383 72.73% ████████░░
rust/eid-vectors/src/curves.rs 87.16% 190/218 85.71% █████████░
rust/eid-prover/src/sod.rs 89.52% 111/124 71.43% █████████░

7 further file(s) not shown.

Reported, not enforced. Out-of-process suites (devnet e2e, testcontainers) do not appear in these numbers.

@tonyvelichko
tonyvelichko merged commit c14f478 into main Oct 1, 2026
16 checks passed
@tonyvelichko
tonyvelichko deleted the ci/packs-unchanged-circuits branch October 1, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant