Repository navigation
build: depend on noir-zk 0.3.3, refrozen as eid-circuits@0.8.2 - #33
Merged
Merged
Conversation
A dependency or toolchain move changes what consumers link against: a combining crate must pin noir-zk exactly as this crate does, so a build commit releases a patch like a fix.
The CDN answered 403 for longer than the 2.5 minutes of retries after v0.8.1's upload, as after v0.8.0's: the check failed though every pack was served minutes later.
noir-zk 0.3.3's kernels take the verification key's hash as a witness (bb constrains it), hash each Merkle level once, and have new keys and a new family root; its freeze compares ABIs as JSON. noir-zk-core, -backend and -codegen move to =0.3.3 (and with them the CLI mise installs), exactly as zk-encryption v0.1.3 pins them, so a combining crate links both. Refrozen as eid-circuits@0.8.2, the release this ships in: no bytecode changes (0 versions minted), the library version and so the family roots change; the registry test's version follows.
Contributor
Code coverage76.12% of lines covered.
8 file(s) below 90% line coverage
7 further file(s) not shown. Reported, not enforced. Out-of-process suites (devnet e2e, testcontainers) do not appear in these numbers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the coordinated repin to noir-zk 0.3.3 (zk-experiments/noir-zk#10), with zk-encryption v0.1.3 (zk-experiments/zk-encryption#5).
noir-zk-core,-backend,-codegen=0.3.3(the CLImise run install:noir-zkreads the same pin), exactly as zk-encryption v0.1.3, so emit-devnet links both.eid-circuits@0.8.2, the release thisbuild:commit cuts: 0 versions minted, the library version and so the family roots change.ci(release):build:commits release a patch (as in zk-encryption).ci(packs): the published-downloads check retries for up to 10 minutes; v0.8.1's failed after 2.5 minutes of CDN 403s although every pack was served soon after (its release notes' packs table was added by hand).Checked: cargo fmt, CI's clippy set,
cargo test --all-features, everyeid-vectors --check, and the fold test with noir-zk 0.3.3's kernels (4 chains proven and verified).