Repository navigation
Skip iOS CI for metadata edits and stop cancelled UI jobs - #58
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to The scope classifier does not skip iOS validation for the investigated unusual filename case. No merge-blocking issue is established. Pre-merge checks |
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@coderabbitai review |
✅ Action performedReview finished.
|
App Store uploader edits currently trigger an app build and two simulator suites, taking about 30 minutes despite changing no iOS inputs. CI now skips Swift formatting, lint, build and UI jobs only for the documented metadata, documentation and marketing paths. Tool, release and secret checks remain; app inputs, workflows, the simulator harness, unknown paths and manual dispatch still receive full iOS validation. Required check names are preserved.
Cancelled UI runs also kept exporting artifacts and shutting down the simulator, delaying the next run by almost five minutes. These remaining steps now use
!cancelled(): ordinary test failures still retain evidence and run cleanup; cancelled jobs stop this work on their disposable hosted VM. Actual cancellation latency still needs observation.Validation: nine tests exercise real Git diffs, including renames, deletions, mixed changes and invalid refs; all 71 script tests and actionlint pass. Independent correctness and acceptance reviews found no issues. No app interface or capture inputs changed, so simulator screenshots do not apply. All four required checks and hosted release/evidence tool checks passed on
efc52a2; both UI suites also passed. Codex and CodeRabbit completed review without actionable findings. The workflow change correctly selected full iOS validation; the separate screenshot capture workflow keeps its own triggers.