Verify active App Store screenshot placements

[zigdanis]

The live Apple inventory reports ACTIVE for the four new English screenshot placements in the editable 2.1.0 draft. The uploader expected PARENT_PREPARE_FOR_SUBMISSION and rejected them, preventing Russian uploads and removal of inherited size-specific sets. This is confirmed by the protected inventory run, rather than the earlier processing-state hypothesis.

Verify ACTIVE placements and check the parent version’s PREPARE_FOR_SUBMISSION state separately. Image properties, exact order, rejected states and bounded processing waits remain enforced; the incorrect successful-state path is removed.

Validation: the captured ACTIVE contract reproduced the failure before the fix; 22 uploader tests and all 54 script tests now pass. Coverage includes all eight localized outputs and refusal to report an in-review parent as editable despite active placements. Independent correctness and acceptance reviews passed with no findings; CI is pending. No app or capture inputs changed, so simulator screenshots do not apply to this uploader-only change; accepted images remain in PR #54. The next live upload will confirm completion.

Note

Fix verify_placements to require ACTIVE screenshot placements

Updates the verify_placements helper in app-store-metadata.py so only ACTIVE placements count as complete. ASSET_PROCESSING still marks a placement as pending. Behavioral Change: all other states now raise an error naming ACTIVE as the expected state, including the former parent-preparation state that previously passed.

^{Macroscope summarized 6415a2b.}

Summary by CodeRabbit

• Bug Fixes
  • Screenshot upload verification now recognizes ACTIVE placements as complete and continues waiting while placements are processing.
  • Placements in other states, including failed, inactive, or unexpected states, now produce an error that identifies the placement and its observed state instead of being treated as successful. This makes incomplete or unsuccessful uploads clearer.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: zigdanis/GrowingUp/.coderabbit.yaml
• Review profile: CHILL
• Plan: Advanced
• Run ID: 8f455a53-0838-41e5-81b6-85b5e9b72f69

---

📥 Commits

Reviewing files that changed from the base of the PR and between 7cf3d9a and 6415a2b.

---

📒 Files selected for processing (1)

• scripts/tests/test_app_store_metadata.py

---

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

---

📝 Walkthrough

Walkthrough

Placement verification now accepts ACTIVE placements as complete and keeps ASSET_PROCESSING pending. Tests cover locale uploads, processing transitions, and errors for other placement states.

Changes

Placement verification

Layer / File(s)	Summary
Placement completion states scripts/app-store-metadata.py, scripts/tests/test_app_store_metadata.py	verify_placements accepts ACTIVE placements and keeps ASSET_PROCESSING pending. Tests cover locale uploads, processing transitions, and error states.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

---

Merge Risk: ⚪ Minimal · up to 6415a

The upload path preserves image and order checks, waits during processing, and verifies parent-version editability separately. No concrete issue requiring a merge block is established.

Pre-merge checks | 4 | 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 8.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check		The title clearly identifies the main change: verifying active App Store screenshot placements.
Description check		The description explains the behavior change, validation results, test coverage, remaining CI status, and why visual evidence does not apply. It does not use the template headings exactly, but it prov…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

---

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

---

---

---

---

---

---

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

---

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-10T12:02:02.056739Z	6415a2b	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[zigdanis]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 6415a2bd36

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[zigdanis]

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[zigdanis]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.