Skip to content

Make PR screenshots and videos fit laptop screens - #56

Merged
zigdanis merged 8 commits into
masterfrom
t3/scale-pr-screenshots
Oct 10, 2026
Merged

zigdanis merged 8 commits into
masterfrom
t3/scale-pr-screenshots

Conversation

@zigdanis

@zigdanis zigdanis commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

Change

Large simulator screenshots can exceed an ordinary laptop screen in PR descriptions. Like WhoGaveWhat #24, the evidence publisher now uploads proportional PNG and MP4 copies within 320×640 pixels and groups screenshots two per paragraph. Original CI media stays intact; temporary copies are checked before uploads and removed on success or failure.

Every screenshot in any PR must follow the compact media rules in docs/remote-ios-verification.md. This standing requirement is linked from the agent instructions, visual acceptance skill, and PR template; reviewed CI screenshots use the evidence publisher. GrowingUp still accepts either relevant screenshots or video and retains its CI/App Store evidence checks. Video finalization preserves frame timing and duration, including variable frame rates and audio offsets.

Verification

Final focused real-media checks passed for four variable-frame-rate cases and a rational frame rate with an audio/video offset. They verify exact frame timing, shifted starts, source B-frames, and the final sample duration. Independent acceptance and correctness reviews found no remaining issues. git diff --check, shell syntax checks, and secret-pattern checks passed.

The current-head Evidence Tools check passed. Its helper suite covers 61 tests, including proportional sizing, original preservation, codecs/audio/fast start, preflight errors, cleanup, and screenshot layout. Codex completed review of 0aa5c62 with no findings or review threads; CodeRabbit was unavailable because its free review quota was exhausted. All four required checks passed on 0aa5c62, including the iOS build and tests. The additional app UI test jobs are still running; this PR changes tooling and instructions only.

Visual acceptance

This changes PR evidence tooling and instructions, with no visible app effect. Functional acceptance uses real media conversion and publication checks; app screenshots do not apply. No TestFlight deployment is requested.

Note

Compact PR screenshots and videos to fit laptop screens in pr-visual-evidence.py

  • Adds a compact_media pipeline in pr-visual-evidence.py that converts screenshots and videos into bounded upload copies (320×640, 10 MiB limit). Videos are re-encoded as fast-start H.264/yuv420p MP4 with AAC audio, even dimensions, and preserved packet timing
  • Source media validation now only requires nonempty files with valid PNG or MP4 signatures; oversized sources are compacted instead of rejected. Temporary derivatives are uploaded and removed on every exit path
  • Published PR bodies group screenshots in pairs with filename-derived labels, and each video URL sits on its own line
  • Documents the compact media rules and ffmpeg workflow in remote-ios-verification.md, and updates the PR template, AGENTS.md, and CI to install ffmpeg and follow the new rules
  • Expands tests in test_pr_visual_evidence.py with ffmpeg-generated fixtures covering compaction invariants, variable/rational frame timing, cleanup on failure, and grouped publication
  • Behavioral Change: evidence publication now requires ffmpeg and ffprobe for video input, and accepts oversized sources that were previously rejected before conversion

Macroscope summarized 0aa5c62.

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository: zigdanis/GrowingUp/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0d08bd84-e49c-49e2-9f4a-5c92b1925af3

📥 Commits

Reviewing files that changed from the base of the PR and between 1a4a1cd and 0aa5c62.


📒 Files selected for processing (7)
  • .agents/skills/visual-acceptance/SKILL.md
  • .github/pull_request_template.md
  • .github/workflows/ci.yml
  • AGENTS.md
  • docs/remote-ios-verification.md
  • scripts/pr-visual-evidence.py
  • scripts/tests/test_pr_visual_evidence.py

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zigdanis
zigdanis marked this pull request as ready for review October 10, 2026 11:46
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-10T11:48:03.689416Z 0aa5c62 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@zigdanis
zigdanis merged commit f32d67c into master Oct 10, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant