Repository navigation
Make PR screenshots and videos fit laptop screens - #56
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 56 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Change
Large simulator screenshots can exceed an ordinary laptop screen in PR descriptions. Like WhoGaveWhat #24, the evidence publisher now uploads proportional PNG and MP4 copies within 320×640 pixels and groups screenshots two per paragraph. Original CI media stays intact; temporary copies are checked before uploads and removed on success or failure.
Every screenshot in any PR must follow the compact media rules in
docs/remote-ios-verification.md. This standing requirement is linked from the agent instructions, visual acceptance skill, and PR template; reviewed CI screenshots use the evidence publisher. GrowingUp still accepts either relevant screenshots or video and retains its CI/App Store evidence checks. Video finalization preserves frame timing and duration, including variable frame rates and audio offsets.Verification
Final focused real-media checks passed for four variable-frame-rate cases and a rational frame rate with an audio/video offset. They verify exact frame timing, shifted starts, source B-frames, and the final sample duration. Independent acceptance and correctness reviews found no remaining issues.
git diff --check, shell syntax checks, and secret-pattern checks passed.The current-head Evidence Tools check passed. Its helper suite covers 61 tests, including proportional sizing, original preservation, codecs/audio/fast start, preflight errors, cleanup, and screenshot layout. Codex completed review of
0aa5c62with no findings or review threads; CodeRabbit was unavailable because its free review quota was exhausted. All four required checks passed on0aa5c62, including the iOS build and tests. The additional app UI test jobs are still running; this PR changes tooling and instructions only.Visual acceptance
This changes PR evidence tooling and instructions, with no visible app effect. Functional acceptance uses real media conversion and publication checks; app screenshots do not apply. No TestFlight deployment is requested.
Note
Compact PR screenshots and videos to fit laptop screens in
pr-visual-evidence.pycompact_mediapipeline in pr-visual-evidence.py that converts screenshots and videos into bounded upload copies (320×640, 10 MiB limit). Videos are re-encoded as fast-start H.264/yuv420p MP4 with AAC audio, even dimensions, and preserved packet timingMacroscope summarized 0aa5c62.