Repository navigation
Wait for Apple screenshot placements and report rejected states - #55
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughPlacement verification now treats ChangesScreenshot placement readiness
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant UploadFlow
participant wait_for_placements
participant api
UploadFlow->>wait_for_placements: Wait for placement readiness
loop While placements are processing
wait_for_placements->>api: Read placement states
api-->>wait_for_placements: Return current placement states
end
wait_for_placements-->>UploadFlow: Return ready placements or raise timeout
Merge Risk: ⚪ Minimal · up to The uploader now waits for Apple's processing state and reports rejected states clearly. No merge-blocking risk was found in the supplied changes. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 5.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 20 functions across 2 files. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly identifies the main change: waiting for Apple screenshot placements and reporting rejected states. |
| Description check | |
The description explains the behavior change, verification coverage, visual-evidence rationale, pending macOS CI, and remaining diagnostic limitation. It omits the template headings, but it includes t… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
- Commit to this branch
- Create a new PR
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
1 participant
The App Store screenshot upload created the 2.1.0 draft and four processed English images, then stopped at placement verification with a generic state error on three attempts. Russian images and cleanup of inherited size sets have not run; the live placement state was not captured.
Wait up to five minutes only for Apple’s documented ASSET_PROCESSING placement state. Every read still validates exact image properties and order; failed or unexpected parent states stop immediately with the actual state. Inventory receipts also expose placement_state, and the final editable-version check remains required.
Validation: 53 script tests pass, including processing-to-ready, timeout without old-set cleanup, failed/reviewed state rejection, order/asset mismatch, inventory state reporting, and final parent-state rejection. No app or capture inputs changed, so simulator screenshots do not apply to this uploader-only change; the accepted screenshots and animation remain in merged PR #54. Independent correctness and acceptance reviews passed with no findings; macOS CI is pending. The actual live failure cause remains unconfirmed until the improved diagnostic runs with the protected master credentials.
Summary by CodeRabbit
Note
Wait for Apple screenshot placements to become ready and report rejected states
wait_for_placementspolling to app-store-metadata.py. It rereads placements for up to 5 minutes, rechecking ordering and asset verification on each poll, with a 5-second sleep while processingverify_placementsnow accepts processing as temporary pending, but raises an error naming the placement ID and state for failed or other non-editable statesMacroscope summarized 4c02c82.