Repository navigation
Show health when looking at any part of a hitbox (3.7.1) - #76
Merged
Merged
Conversation
On 1.13.2+, Show On Look now ray traces the entity's hitbox. Large mobs and ModelEngine models show their health when the player looks at their body, not only near their feet. ModelEngine resizes the real mob's hitbox to fit the model, so no ModelEngine code is needed. Targets are sorted nearest first. getTarget now returns at a distance of 0, because BlockIterator treats 0 as no limit and could freeze the server when a player stood at an entity's position. Add a ModelEngine e2e check (integrations.sh, needs a local ModelEngine jar) and rewrite the README. Version 3.7.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
getTargetreturns at a distance of 0.BlockIteratortreats 0 as no limit, so a player at an entity's exact position made the check walk the view line and load chunks. The new hitbox check made this case more likely, and the ModelEngine test found it.Why no ModelEngine code
I tested with the free Legacy Model Engine Demo (R3.1.11) on Spigot 1.20.4:
Invisible Potiondoes not affect models.ModelEngine R4 has no free version, so it was not tested.
Tests
MODE=modelenginee2e check. It runs inintegrations.shwhen aModelEngine-*.jaris incompat/.cache/plugins. 3.7.0 fails the two checks that look up at the body. 3.7.1 passes all 5.Closes #44.
🤖 Generated with Claude Code