fix(urltest): probe policy members with bounded concurrency - #2
Merged
Conversation
kovawx
force-pushed
the
agent/concurrent-urltest-probes
branch
from
August 3, 2026 05:18
3436a76 to
fc7fe2e
Compare
kovawx
marked this pull request as ready for review
August 3, 2026 05:24
kovawx
force-pushed
the
agent/concurrent-urltest-probes
branch
from
August 3, 2026 05:26
4f53481 to
fc7fe2e
Compare
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
diagnostics.probe_outboundin the same process-wide concurrency budgetpolicy.probe.completedeventsUpdated develop integration
This branch has been rebuilt on the current
developruntime model.EngineRuntimeSnapshotheld byTcpRuntimeServicescrates/proxy/Cargo.tomlandcrates/proxy/src/groups/urltest.rsRoot cause
The previous implementation awaited every member in sequence, so one group could take approximately
member_count × 5s. Separate URLTest groups and direct diagnostic probes could also multiply the number of simultaneous sockets, while overlapping requests for the same target repeated DNS resolution and connection work.Expected effect
For a group containing 44 nodes, up to eight real probes run concurrently across the process. Requests that overlap for the same runtime configuration, target, and URL share one in-flight operation. Each group still commits its own ordered member state and emits its own completion event.
Compatibility
The command and event contracts are unchanged.
policy.probe.completedcontinues to contain all members in configuration order and is emitted after the group state is committed.Validation