Skip to content

#695: give every fake event the same repo shape - #714

Open
morphqdd wants to merge 1 commit into
zerocracy:masterfrom
morphqdd:695
Open

#695: give every fake event the same repo shape#714
morphqdd wants to merge 1 commit into
zerocracy:masterfrom
morphqdd:695

Conversation

@morphqdd

@morphqdd morphqdd commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Three events carried repo: { id: <number>, name: <full name>, url: ... } while
the last two, and the nested base.repo, carried repo: { id: <full name> }, so
in one array e[:repo][:id] was an Integer for some events and a String for
others, and [:name] was missing. The event id also flipped from String to
Integer, while the real Events API always returns a String.

Every element uses the same shape now.

Closes #695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fake client's repository_events returns two incompatible repo shapes in one array

1 participant