#685: deduct per comment above the threshold - #708
Open
morphqdd wants to merge 1 commit into
Open
Conversation
Member
|
Thanks — matches the reported arithmetic mismatch and updates the bill test accordingly. CI is green. @rultor merge Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bylaw text promises 0.2 points off for every comment above the threshold, the
formula charged 0.2 for every comment, including the ones below it. With 24
comments the text said 3.2 and the code computed 4.8.
The formula counts only the comments above the threshold now, and the text says
that nothing is deducted until the floor is reached, which was also unstated.
One expected number in
test_check_all_billsmoves with it.Closes #685