#679: keep the bonus earned up to the threshold - #707
Open
morphqdd wants to merge 1 commit into
Open
Conversation
Member
|
Thanks — smooths the hits-of-code cliff at the threshold, with a regression test and updated bill expectations. CI is green. @rultor merge Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At
hoc == hoc_thresholdthe whole hits-of-code bonus was thrown away and thepenalty was added at the same instant, so one extra line in the diff cost 16
points with the shipped defaults.
The bonus is now counted up to the threshold and kept there, and only the penalty
applies above it, so the transition is the penalty itself and nothing more.
The expected numbers in
test_check_all_billsmove with it, for the four inputsat or above the threshold.
Closes #679