#680: make the printed lines add up to the total - #706
Open
morphqdd wants to merge 1 commit into
Open
Conversation
Member
|
Thanks — makes the itemised lines and the total round the same way. Small, focused, tested. CI is green. @rultor merge Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pointsrounded the sum of the raw values whilegreetingformatted each linewith
%+d, which truncates, so the itemised list and the headline numberdisagreed. On the shipped bylaws this happened for a large share of the inputs.
Each line is rounded now, and the total is the sum of those rounded lines, so the
numbers a contributor is shown add up to what they are told they earned.
Closes #680