Count a release published exactly at since, and stop early despite a draft - #678
Open
Thayorns wants to merge 2 commits into
Open
Count a release published exactly at since, and stop early despite a draft#678Thayorns wants to merge 2 commits into
Thayorns wants to merge 2 commits into
Conversation
… early despite a draft
Author
|
@yegor256 please take a look, happy to clarify anything. |
Member
|
This touches the same Generated by Claude Code |
This was referenced Sep 3, 2026
yegor256
self-requested a review
September 3, 2026 06:22
Author
|
@yegor256 take a look please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release count in `total_releases_published` compared with a strict `>`, while the early-exit check compared with a strict `<`. A release published at exactly the `since` boundary satisfied neither, so it was dropped from the count without stopping the scan. Judges call this method with a boundary computed from a previous run, making that instant a likely value to land on.
The two checks also disagreed about drafts: the count skips them via `isDraft`, but the exit check only looked at `publishedAt`, which is null for a draft. A single draft anywhere on a page made the exit check false, so a repository with a draft near the top of its release list scanned its entire history one page at a time.
This makes the count inclusive on the boundary (`>= since`) and has the exit check treat a draft the same way the count does, so a draft no longer defeats the short-circuit.
Closes #662