Skip to content

Count a release published exactly at since, and stop early despite a draft - #678

Open
Thayorns wants to merge 2 commits into
zerocracy:masterfrom
Thayorns:662
Open

Count a release published exactly at since, and stop early despite a draft#678
Thayorns wants to merge 2 commits into
zerocracy:masterfrom
Thayorns:662

Conversation

@Thayorns

@Thayorns Thayorns commented Sep 2, 2026

Copy link
Copy Markdown

The release count in `total_releases_published` compared with a strict `>`, while the early-exit check compared with a strict `<`. A release published at exactly the `since` boundary satisfied neither, so it was dropped from the count without stopping the scan. Judges call this method with a boundary computed from a previous run, making that instant a likely value to land on.

The two checks also disagreed about drafts: the count skips them via `isDraft`, but the exit check only looked at `publishedAt`, which is null for a draft. A single draft anywhere on a page made the exit check false, so a repository with a draft near the top of its release list scanned its entire history one page at a time.

This makes the count inclusive on the boundary (`>= since`) and has the exit check treat a draft the same way the count does, so a draft no longer defeats the short-circuit.

Closes #662

@Thayorns

Thayorns commented Sep 2, 2026

Copy link
Copy Markdown
Author

@yegor256 please take a look, happy to clarify anything.

yegor256 commented Sep 3, 2026

Copy link
Copy Markdown
Member

This touches the same total_releases_published boundary condition as #671, via a different approach — only one should be merged. Assigning to @yegor256 to reconcile.


Generated by Claude Code

@Thayorns

Thayorns commented Sep 3, 2026

Copy link
Copy Markdown
Author

@yegor256 take a look please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

total_releases_published drops a release published exactly at since in lib/fbe/github_graph.rb

2 participants