Pin down how query answers a path-scoped GitHub error - #668
Open
Thayorns wants to merge 2 commits into
Open
Conversation
Author
|
@yegor256 happy to clarify anything about this fix if needed. |
Member
|
This looks like a near-duplicate fix of the same Generated by Claude Code |
yegor256
self-requested a review
September 3, 2026 06:22
Author
|
@yegor256 take a look please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
graphql-client stamps a not-found error like
path: ["repository"]asnormalizedPath: ["data", "repository"]oncedataitself is non-null, andresult.errorsonly surfaces errors whose normalized path has no extra segment. That is what this issue was about, and #672 has since fixed it on master:querynow foldsresult.data.errorsinto the same message list, so a renamed or deleted repository raisesFbe::Errorinstead of returning a stray nil.Since the production fix already landed, this branch keeps only what was missing around it. Three tests now pin the behavior down: a path-scoped error arriving together with partial data still raises rather than handing the caller a half-filled result, a top-level error is not swallowed when a path-scoped one sits beside it, and a null
datawith no errors at all is left alone instead of blowing up ondata.errors.Closes #655