Raise Fbe::Error in pull_request_reviews when repository is missing - #667
Open
Thayorns wants to merge 2 commits into
Open
Raise Fbe::Error in pull_request_reviews when repository is missing#667Thayorns wants to merge 2 commits into
Thayorns wants to merge 2 commits into
Conversation
…ository is missing Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B6v8tZqHAFpr3qBg8bLL8X
Author
|
@yegor256 please take a look, happy to clarify anything. |
Member
|
This PR now has merge conflicts and needs a rebase before it can go in. Assigning to @yegor256 for a look. Generated by Claude Code |
yegor256
self-requested a review
September 3, 2026 06:21
…in pull_request_reviews
Thayorns
changed the title
Author
|
@yegor256 take a look please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull_request_reviewsmapped overresult['repository']without checking whether the key was present, so a missing repository surfaced asundefined method 'map' for nilseveral frames away from the owner and name that caused it.Its twin
pull_requests_with_reviewsalready guards the same shape and raises a namedFbe::Error, andtotal_commits_pushedpicked up the same guard in #675. This copies it once more so all three answer the same way when the repository cannot be resolved.Three tests drive it: a response carrying only
errors, a response carryingrepository: null, and a response carrying an emptyrepositoryobject, which is the case that must keep returning an empty list rather than raising. The second one builds its owner from a seed so a failure names the value it ran on.Closes #657