⚡ Bolt: Fix N+1 query problem in PoolController - #62
Conversation
Batched database key fetch to eliminate N+1 latency. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Added
getLocalKeysForAccountsto batch-fetch keys for multiple accounts in a single query, replacing the per-accountgetLocalKeysquery inPoolController's main account mapping loop.🎯 Why: The existing
PoolController.getPoolDataloop hit the database independently to get local keys for every single account loaded. This caused an N+1 query problem resulting in high latency when a user has many accounts in their Hydra instance.📊 Impact: Reduces database queries in
/api/poolfrom O(N) to O(1) where N is the number of accounts. Substantially decreases server load and speeds up the Pool Manager loading time on large account lists.🔬 Measurement: Verify by testing the
/api/poolendpoint with a large number of accounts. The database query logs will show 1 fetch rather than N.PR created automatically by Jules for task 3205942739633734401 started by @zaydiscold