Fix ISO date conversion bug - #357
Open
bikerpatch wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the ISO date conversion bug in #356
The adjusted code, on polish, will first look for a value in
data["Meta Data"]?.["6. Time Zone"]and pass it to the recursive function to polish the object. If it can't find a value it will default to UTC, which could lead into the same bug as before, but in the absence of a time zone from AV we have to assume something reasonable. I couldn't find a default timezone in the documentation. If you prefer, this could be changed to default to US Eastern.When the polish routine finds a timestamp in the data, it will apply the timezone using the
luxonlibrary: https://moment.github.io/luxon/#/zones