Feature/pbl m ylv2 - #550
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new MYNN Level 2 planetary boundary layer (PBL) scheme to the nonhydrostatic atmosphere model (including diagnostic outputs and a new boundary-layer test case), and fixes a hydrostatic basic-state bug when PTLAPS = 0 (Issue #549).
Changes:
- Implement MYNN Level 2 PBL turbulence parameterization (new BL common + MYNN Lv2 modules) and wire it into
AtmosPhyBl, history output, and build system (Issue #547). - Add a new
boundary_layertest case configuration + user init + visualization helper. - Fix division-by-zero in
hydrostatic_calc_basicstate_constPTLAPSwhenPTLAPSis zero (Issue #549).
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| model/atm_nonhydro3d/test/case/boundary_layer/visualize/visualize.sh | Adds plotting commands for boundary-layer testcase outputs. |
| model/atm_nonhydro3d/test/case/boundary_layer/run.conf | Adds runtime config enabling BL_TYPE='MYNN_LEVEL2' and output variables. |
| model/atm_nonhydro3d/test/case/boundary_layer/mod_user.F90 | Adds testcase-specific initialization (incl. PTLAPS=0 path exercising the bugfix). |
| model/atm_nonhydro3d/test/case/boundary_layer/Makefile | Adds build/run harness for the new testcase. |
| model/atm_nonhydro3d/test/case/boundary_layer/init.conf | Adds init configuration for the new testcase. |
| model/atm_nonhydro3d/src/atmos/mod_atmos_phy_bl.F90 | Wires in MYNN Lv2 BL scheme, diagnostics, boundary-condition handling, and tendency application. |
| model/atm_nonhydro3d/src/atmos/mod_atmos_phy_bl_vars.F90 | Adds BL diagnostic variables (TKE/NU/KH) and history output handling. |
| model/atm_nonhydro3d/src/atmos/mod_atmos_component.F90 | Passes dynamical-core boundary-condition handler into the PBL process. |
| model/atm_nonhydro3d/src/admin/mod_dg_driver.F90 | Adds BL process history output calls. |
| FElib/src/Makefile | Adds BL turbulence objects to the library build. |
| FElib/src/fluid_dyn_solver/scale_atm_dyn_dgm_hydrostatic.F90 | Fixes PTLAPS=0 branch in hydrostatic basic-state calculation. |
| FElib/src/depend | Adds dependency rules for new BL turbulence modules. |
| FElib/src/bl_turbulence/scale_atm_phy_bl_dgm_mynn_lv2.F90 | New MYNN Level 2 diagnostic closure implementation (diffusivities + TKE). |
| FElib/src/bl_turbulence/scale_atm_phy_bl_dgm_common.F90 | New shared BL vertical-implicit diffusion/tendency machinery. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #547
close #549