Skip to content

Feature/simple rad scheme - #546

Merged
ywkawai merged 13 commits into
developfrom
feature/simple_rad_scheme
Jul 18, 2026
Merged

Feature/simple rad scheme#546
ywkawai merged 13 commits into
developfrom
feature/simple_rad_scheme

Conversation

@ywkawai

@ywkawai ywkawai commented Jul 18, 2026

Copy link
Copy Markdown
Owner

close #544
close #533

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Implements the “simple” radiation framework (Vallis et al., 2018) with optional idealized solar insolation (Issue #544, #533), updates model wiring to provide surface albedo to radiation, and refreshes related test/case configurations and outputs.

Changes:

  • Replaces the prior gray-radiation implementation with a new simplified radiation module supporting Gray and LW(2-band)+SW(1-band) options, including surface SW/LW up/down flux outputs.
  • Introduces a simple solar insolation module and hooks it into the atmospheric radiation component.
  • Refactors topography reading into a shared mesh method and updates test case configs/scripts accordingly.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
model/atm_nonhydro3d/test/case/radiation/visualize/visualize.sh Adds a visualization helper script for radiation case outputs.
model/atm_nonhydro3d/test/case/radiation/run.conf Switches radiation scheme configuration to RD_TYPE='SIMPLE' and adds SIMPLE radiation namelist.
model/atm_nonhydro3d/test/case/radiation/Makefile Adjusts test Makefile (removes POSTFIX usage).
model/atm_nonhydro3d/test/case/radiation/init.conf Enables surface & radiation physics flags and sets RD_TYPE='SIMPLE'.
model/atm_nonhydro3d/test/case/coupling/atm_ocn/run.conf Switches coupled case to SIMPLE radiation + adds simple insolation namelist and additional history outputs.
model/atm_nonhydro3d/test/case/coupling/atm_ocn/init.conf Updates coupled init to use RD_TYPE='SIMPLE'.
model/atm_nonhydro3d/src/atmos/mod_atmos_phy_rd.F90 Wires SIMPLE radiation, adds solar-insolation scheme selection, and passes surface albedo into radiation.
model/atm_nonhydro3d/src/atmos/mod_atmos_mesh.F90 Adds Read_topography_file type-bound procedure for shared topography IO behavior.
model/atm_nonhydro3d/src/atmos/mod_atmos_mesh_rm.F90 Uses the shared mesh topography reader instead of duplicating IO logic.
model/atm_nonhydro3d/src/atmos/mod_atmos_mesh_gm.F90 Uses the shared mesh topography reader instead of duplicating IO logic.
model/atm_nonhydro3d/src/atmos/mod_atmos_component.F90 Passes both surface temperature and albedo to the radiation component.
FElib/src/radiation/scale_atm_phy_rd_solarins_simple.F90 Adds an idealized solar insolation module (CONST / ANNUAL_MEAN).
FElib/src/radiation/scale_atm_phy_rd_dgm_simple.F90 Adds the new simplified radiation implementation (Gray and LWbnd2+SWbnd1).
FElib/src/radiation/scale_atm_phy_rd_dgm_gray.F90 Removes the prior gray-radiation module.
FElib/src/Makefile Updates radiation object list and adds a new scale library object dependency.
FElib/src/file/scale_file_restart_meshfield.F90 Makes dim_name_postfix length flexible (len=*) in restart component init routines.
FElib/src/file/scale_file_history_meshfield.F90 Adjusts pointer typing for target_comp variables.
FElib/src/file/scale_file_base_meshfield.F90 Makes dim_name_postfix length flexible and allows get_comp without an explicit component id.
FElib/src/depend Updates build dependencies for new radiation/insolation objects.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread FElib/src/radiation/scale_atm_phy_rd_dgm_simple.F90
Comment thread FElib/src/radiation/scale_atm_phy_rd_solarins_simple.F90
Comment thread FElib/src/radiation/scale_atm_phy_rd_solarins_simple.F90
Comment thread model/atm_nonhydro3d/src/atmos/mod_atmos_mesh.F90
Comment thread model/atm_nonhydro3d/src/atmos/mod_atmos_phy_rd.F90
Comment thread FElib/src/Makefile
@ywkawai
ywkawai merged commit 5b3bdfb into develop Jul 18, 2026
2 checks passed
@ywkawai
ywkawai deleted the feature/simple_rad_scheme branch July 20, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants