Feature/simple rad scheme - #546
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Implements the “simple” radiation framework (Vallis et al., 2018) with optional idealized solar insolation (Issue #544, #533), updates model wiring to provide surface albedo to radiation, and refreshes related test/case configurations and outputs.
Changes:
- Replaces the prior gray-radiation implementation with a new simplified radiation module supporting Gray and LW(2-band)+SW(1-band) options, including surface SW/LW up/down flux outputs.
- Introduces a simple solar insolation module and hooks it into the atmospheric radiation component.
- Refactors topography reading into a shared mesh method and updates test case configs/scripts accordingly.
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| model/atm_nonhydro3d/test/case/radiation/visualize/visualize.sh | Adds a visualization helper script for radiation case outputs. |
| model/atm_nonhydro3d/test/case/radiation/run.conf | Switches radiation scheme configuration to RD_TYPE='SIMPLE' and adds SIMPLE radiation namelist. |
| model/atm_nonhydro3d/test/case/radiation/Makefile | Adjusts test Makefile (removes POSTFIX usage). |
| model/atm_nonhydro3d/test/case/radiation/init.conf | Enables surface & radiation physics flags and sets RD_TYPE='SIMPLE'. |
| model/atm_nonhydro3d/test/case/coupling/atm_ocn/run.conf | Switches coupled case to SIMPLE radiation + adds simple insolation namelist and additional history outputs. |
| model/atm_nonhydro3d/test/case/coupling/atm_ocn/init.conf | Updates coupled init to use RD_TYPE='SIMPLE'. |
| model/atm_nonhydro3d/src/atmos/mod_atmos_phy_rd.F90 | Wires SIMPLE radiation, adds solar-insolation scheme selection, and passes surface albedo into radiation. |
| model/atm_nonhydro3d/src/atmos/mod_atmos_mesh.F90 | Adds Read_topography_file type-bound procedure for shared topography IO behavior. |
| model/atm_nonhydro3d/src/atmos/mod_atmos_mesh_rm.F90 | Uses the shared mesh topography reader instead of duplicating IO logic. |
| model/atm_nonhydro3d/src/atmos/mod_atmos_mesh_gm.F90 | Uses the shared mesh topography reader instead of duplicating IO logic. |
| model/atm_nonhydro3d/src/atmos/mod_atmos_component.F90 | Passes both surface temperature and albedo to the radiation component. |
| FElib/src/radiation/scale_atm_phy_rd_solarins_simple.F90 | Adds an idealized solar insolation module (CONST / ANNUAL_MEAN). |
| FElib/src/radiation/scale_atm_phy_rd_dgm_simple.F90 | Adds the new simplified radiation implementation (Gray and LWbnd2+SWbnd1). |
| FElib/src/radiation/scale_atm_phy_rd_dgm_gray.F90 | Removes the prior gray-radiation module. |
| FElib/src/Makefile | Updates radiation object list and adds a new scale library object dependency. |
| FElib/src/file/scale_file_restart_meshfield.F90 | Makes dim_name_postfix length flexible (len=*) in restart component init routines. |
| FElib/src/file/scale_file_history_meshfield.F90 | Adjusts pointer typing for target_comp variables. |
| FElib/src/file/scale_file_base_meshfield.F90 | Makes dim_name_postfix length flexible and allows get_comp without an explicit component id. |
| FElib/src/depend | Updates build dependencies for new radiation/insolation objects. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #544
close #533