Close interrupted runs during restart recovery - #9
Draft
yubnsbski wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interruptedended_at,error_class, and a structured interruption reasontask.recoveredevidence in one SQLite transactionRoot cause
Restart recovery moved active tasks back to
queued, but their Run records stayedrunningforever. The dashboard and audit history could therefore claim a model was still active after the process had already died, and a later retry would create another Run beside the orphan.There was also a crash window between committing the recovered task state and writing its audit event because those operations used separate transactions.
Behavior
When WBZ starts and finds a task in
planning,executing,verifying, orreviewing, it atomically:runningRuns asinterrupted;queued;task.recoveredwith the interrupted Run IDs.Calling recovery again makes no further changes.
Validation
python -m pytest -q— 23 passedpython -m compileall -q src testsgit diff --check