[codex] Support repeated exec usings#32
Merged
youngwoocho02 merged 2 commits intoJun 8, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unity-cli exec --usingsto be specified multiple times.--usingsvalues into one de-duplicated array before sending params to Unity./varand/private/varresolve to the same Unity project, while preserving Windows case-insensitive matching.Root Cause
buildParamsstored subcommand flags inmap[string]string, so repeated flags overwrote earlier values.exec --usings A --usings Bonly sent the final namespace to the Unity connector even though the connector already accepts an array.While validating with the repo Go version, an existing
internal/clienttest also exposed a project path normalization gap on macOS: cwd could be reported through/var/...while Unity instance data used/private/var/.... That madeDiscoverInstancemiss the active cwd project and fall through to the multi-instance error.Validation
go1.24.3 darwin/arm64locally fromgo.dev/dlto matchgo.mod./tmp/unity-cli-go-1.24.3/go/bin/gofmt -w cmd/root.go cmd/root_test.go internal/client/client.gogit diff --check/tmp/unity-cli-go-1.24.3/go/bin/go test ./internal/client -run TestDiscoverInstance_UsesCwdProjectMatch -count=1 -v/tmp/unity-cli-go-1.24.3/go/bin/go clean -testcache && /tmp/unity-cli-go-1.24.3/go/bin/go test ./...