Conversation
yl2chen
reviewed
Oct 29, 2021
Comment on lines
+130
to
+131
| net := rnet.NewNetwork(network) | ||
| return p.coveringNetworks(net) |
Owner
There was a problem hiding this comment.
Thanks for the PR! btw is new implementation needed, could we not just do the following?
Suggested change
| net := rnet.NewNetwork(network) | |
| return p.coveringNetworks(net) | |
| return p.ContainingNetworks(network.IP.Mask(network.IPMask)) |
Author
There was a problem hiding this comment.
I thought about this method. But i've discover Covers function, and decided to use it.
monoidic
added a commit
to monoidic/cidranger
that referenced
this pull request
Aug 28, 2022
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added "CoveringNetworks" search feature. It's like ContainingNetworks() for but for IPnet instead of single IP.