Repository navigation
Small fixes for SHIFT and KECCAK_ROUND - #1021
Merged
Merged
Conversation
Kimi Code ReviewAutomated review by Kimi (Moonshot AI) |
Codex Code ReviewNo issues found in the PR diff. The |
erik-3milabs
approved these changes
Oct 15, 2026
erik-3milabs
left a comment
erik-3milabs
left a comment
Collaborator
There was a problem hiding this comment.
Tiny rename remark. Applied or not, this PR is gtg!
Comment on lines
210
to
214
| kind = "interaction" | ||
| tag = "MSB16" | ||
| input = [["idx", "in", 3]] | ||
| kind = "template" | ||
| tag = "SIGN" | ||
| input = [["idx", "in", 3], "signed"] | ||
| output = "is_negative" | ||
| multiplicity = "signed" | ||
| ref = "shift:c:is_negative_if_signed" |
Collaborator
There was a problem hiding this comment.
Rather than calling it is_negative, the variable should probably renamed to sign, no? That would be more inline with how we typically call the variable sitting in the output of the SIGN template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_negativein the SHIFT chip