Repository navigation
Conversation
Every project that uses the StringLocalizer generation gets a public ResXGenerator.Registration.ResXGeneratorRegistrationExtension. When such a project references another one that generates it too, both classes are visible and services.UsingResXGenerator() no longer compiles (CS0121, ambiguous call). ResXGenerator_InternalRegistration=true generates the global and the per-namespace registration classes as internal. The referenced project then offers its registration through a public method of its own. The default stays public, so existing projects are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every project that uses the StringLocalizer generation gets a public ResXGenerator.Registration.ResXGeneratorRegistrationExtension. When such a project references another one that generates it too, both classes are visible and services.UsingResXGenerator() no longer compiles (CS0121, ambiguous call).
ResXGenerator_InternalRegistration=true generates the global and the per-namespace registration classes as internal. The referenced project then offers its registration through a public method of its own. The default stays public, so existing projects are unaffected.