Repository navigation
Conversation
CS1591 - https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs1591 I also added GeneratedCodeAttribute on each generated class to not add warning on destination solution build. Upgrading Nuget Package to latests versions. Replacing Deprecated xunit with xunit.v3 and adjust unit tests.
Replace $(solutionDir) by ../
Replace all new line of AppendLine with AppendLineLF Adjust unit tests Apply extension method NormalizeLineEndings on string interpolation to standardize line feed against existing generators
Testing with VSTest target is no longer supported by Microsoft.Testing.Platform on .NET 10 SDK and later
Spaces in Resource Name Should Produce Valid Property Names ycanardeau#11
Assume StaticClass and StaticMenmber to be false when GenerationType is StringLocalizer
Contributor
Author
|
Hi @ycanardeau, this PR is ready for review whenever you have a chance. Let me know if you'd like any changes. Thanks! |
Contributor
Author
|
Hi @ycanardeau just in case are tou still active in the project ? There are somes pull request since July ? I hope you're fine. Thank-you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With tools like Roslyn or SonarQube, auto-generated code can produce warnings after build. The best way to suppress these warnings is to apply the
System.CodeDom.Compiler.GeneratedCodeattribute. Most code analysis tools recognize this attribute and do not generate a warning during compilation.I also added summary comments to the auto-generated classes to avoid CS1591 warnings.
I also struggled quite a bit with
AppendLineLF. To align our approaches, I added a.NormalizeLineEndings()extension method for interpolated strings. It makes testing much easier and ensures the generated classes use only\n. After re-enablingAppendLF, we had mixed line endings; now everything is consistent as intended.Since support for .NET 8.0 and .NET 9.0 ends this November, I also took the opportunity to migrate the test projects to .NET 10.0.
I also checked the vulnerability alerts for the NuGet packages. I noticed that support for xunit has ended. I migrated the test projects to xunit.v3. This wasn't easy, as it involved switching from VSTests to MSTests.