SEH Windows tests are fixed. - #8
Draft
yasster wants to merge 1 commit into
Draft
Conversation
dpaoliello
suggested changes
Jan 12, 2026
| @@ -2216,27 +2216,44 @@ void CodeGenFunction::ExitSEHTryStmt(const SEHTryStmt &S) { | |||
| return; | |||
| } | |||
|
|
|||
| // Otherwise, we must have an __except block. | |||
| const SEHExceptStmt *Except = S.getExceptHandler(); | |||
| @@ -1754,7 +1750,19 @@ auto CodeGenFunction::GetDestForLoopControlStmt(const LoopControlStmt &S) | |||
| } | |||
|
|
|||
| void CodeGenFunction::EmitBreakStmt(const BreakStmt &S) { | |||
| assert(!BreakContinueStack.empty() && "break stmt not in a loop or switch!"); | |||
| // If we're in an outlined SEH finally function and there's no loop context, | |||
There was a problem hiding this comment.
Is there some other way that we can check this? Can we see that we're in a funclet, or check the functions EH personality?
| @@ -0,0 +1,26 @@ | |||
| // RUN: %clang_cc1 -triple x86_64-windows-msvc -fms-compatibility -emit-llvm -o - %s | FileCheck %s | |||
There was a problem hiding this comment.
Can we add another run of this test without ms-compat and verify the opposite behavior?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.