feat(vite-config): forward extra Vite config to base package config#137
Merged
Conversation
Capture unknown options passed to createBasePackageConfig as restConfig and deep-merge them onto the generated config via mergeConfig. This lets consumers pass standard Vite options (e.g. resolve.alias, server) directly to npmPackageConfig instead of wrapping them in a custom plugin.
There was a problem hiding this comment.
Pull request overview
Enables createBasePackageConfig (and therefore npmPackageConfig / laravelPackageConfig) to accept and apply additional standard Vite config keys by capturing unknown options and deep-merging them onto the generated base config via Vite’s mergeConfig.
Changes:
- Import
mergeConfigfromviteand use it to merge extra user-supplied config into the generated base package config. - Collect unrecognized options passed to
createBasePackageConfigas...restConfigand forward them into the returned Vite config.
e28ff4f to
2507bde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createBasePackageConfigvangt nu onbekende opties op via...restConfigen merged die metmergeConfigop de gegenereerde config.Waarom
We dachten dat dit al werkte, maar extra opties (zoals
resolve) werden nooit doorgegeven aan de uiteindelijke config, nu worden ze wel meegenomen.Hoe gebruik je het
Hoe de data stroomt
resolvereist als gewone optie door drie bestanden:vite.config.js(consumer) — roeptnpmPackageConfig( { entryPoints, resolve } )aan.configs/npm-package.js—npmPackageConfigspreidt...options(incl.resolve) door naarcreateBasePackageConfig.configs/base-package.js—createBasePackageConfigpakt de benoemde opties eruit;resolvevalt in...restConfigen wordt viamergeConfig( baseConfig, restConfig )in de uiteindelijke config gemerged.