Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new mechanism for tracking and displaying the progress of dataset preparation for Geant4 local worker simulations. The changes span both the backend service logic and the frontend UI, enabling users to see more detailed, real-time feedback during the simulation's pending state, especially when datasets are being loaded or prepared.
Key changes include:
Frontend UI Enhancements
SimulationPreparationcomponent inSimulationCardContent.tsxto visually display dataset preparation progress, including stage, counters, and active dataset information. This component is shown when a simulation is in the pending state and dataset preparation is in progress. [1] [2]SimulationCardContentto conditionally show the new preparation progress UI based on simulation status and dataset preparation state. [1] [2]Backend Service & Data Model Updates
DatasetPreparationInfotype (and related types) to the shared response types, capturing detailed preparation progress, stage, and dataset information. This is now included in the job status responses. [1] [2]Geant4LocalWorkerSimulationServiceto track and report dataset preparation progress for each job by:getDatasetPreparation, which computes the current preparation state and progress, including weighted progress across datasets.datasetPreparationinto all relevant job status responses, including paginated and batch queries. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]These improvements provide users with clearer feedback about simulation preparation, especially for jobs that require significant dataset loading or initialization.