Fix optimizer subsref warmstart bug - #1528
Open
tholden wants to merge 1 commit into
Open
Conversation
tholden
marked this pull request as ready for review
May 29, 2026 09:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR was generated by AI. It seems reasonable to me but it probably warrants additional scrutiny. AI text follows:
When partially instantiating an optimizer object, the lastsolution array was not being updated to remove the eliminated parameters, which resulted in a corrupted warm start for subsequent solver calls. This PR fixes the issue by slicing lastsolution using keptvariablesIndex.