UDEFX2: Convert g_LanguageDescriptor type to USB_STRING_DESCRIPTOR - #38
Open
forderud wants to merge 1 commit into
Open
UDEFX2: Convert g_LanguageDescriptor type to USB_STRING_DESCRIPTOR#38forderud wants to merge 1 commit into
forderud wants to merge 1 commit into
Conversation
forderud
force-pushed
the
g_LanguageDescriptor
branch
from
April 2, 2024 15:47
84ab3cb to
926a994
Compare
Owner
|
looks like there's a conflict on this one. |
It's safer to work directly with typed data instead of bytes-arrays. Remove associated NT_ASSERT checks that are now redundant, since they are checking obviously correct struct members.
forderud
force-pushed
the
g_LanguageDescriptor
branch
from
April 5, 2024 07:17
926a994 to
39b3fc5
Compare
Contributor
Author
|
I've now rebased the PR to resolve the conflict. |
Contributor
Author
|
@xxandy Would it be possible for you to consider this PR? |
1 similar comment
Contributor
Author
|
@xxandy Would it be possible for you to consider this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's safer to work directly with typed data instead of bytes-arrays. Remove associated NT_ASSERT checks that are now redundant, since they are checking obviously correct struct members.