Skip to content

Make sure that strings get converted to DimRole for comparison to fix… - #44

Merged
cjtitus merged 2 commits into
masterfrom
slice_reduction_fix
Sep 23, 2026
Merged

cjtitus merged 2 commits into
masterfrom
slice_reduction_fix

Conversation

@cjtitus

@cjtitus cjtitus commented Sep 23, 2026

Copy link
Copy Markdown
Member

… bug in axis reduction

cjtitus and others added 2 commits September 23, 2026 15:34
…ated

Swapping the two plot axes left the new plane drawn against the old
orientation's limits, cut off, until the next slider step.

imshow scales the axes itself, but only while they still autoscale, and
set_xlim ends that for good. The update path calls it, so once a slider
had been stepped the axes no longer autoscaled -- and an orientation
change tears the 2-D axes down and creates the image afresh on the same
Axes, which then kept the previous orientation's limits. Stepping the
slider again took the update path and fixed it, which is what made this
look like a missed refetch rather than a stale scale.

Both paths now go through one _set_limits, as MeshRenderer already did.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@cjtitus
cjtitus merged commit e1f1be4 into master Sep 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant