Skip to content

patch: github.com/xmidt-org/bascule v1.1.9: fix broken auth implementation - #697

Merged
denopink merged 10 commits into
mainfrom
denopink/patch/auth-middleware
Sep 1, 2026
Merged

patch: github.com/xmidt-org/bascule v1.1.9: fix broken auth implementation#697
denopink merged 10 commits into
mainfrom
denopink/patch/auth-middleware

Conversation

@denopink

Copy link
Copy Markdown
Contributor

fix broken auth middleware introduced in #554

@denopink denopink self-assigned this Aug 31, 2026
@denopink denopink added the bug label Aug 31, 2026
@denopink
denopink force-pushed the denopink/patch/auth-middleware branch from f7ec078 to 0f61139 Compare August 31, 2026 21:50
@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 3.67347% with 236 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.32%. Comparing base (2bc589a) to head (05481ed).

Files with missing lines Patch % Lines
metrics.go 0.00% 116 Missing ⚠️
primaryHandler.go 0.00% 81 Missing ⚠️
basculeValidators.go 19.44% 29 Missing ⚠️
keyResolver.go 0.00% 8 Missing ⚠️
WRPAccessControl.go 50.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2bc589a) and HEAD (05481ed). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (2bc589a) HEAD (05481ed)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #697      +/-   ##
==========================================
- Coverage   25.57%   16.32%   -9.26%     
==========================================
  Files           9        9              
  Lines         786      674     -112     
==========================================
- Hits          201      110      -91     
+ Misses        578      564      -14     
+ Partials        7        0       -7     
Flag Coverage Δ
unittests 16.32% <3.67%> (-9.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@denopink
denopink force-pushed the denopink/patch/auth-middleware branch from f5234f8 to 05481ed Compare September 1, 2026 00:24
@denopink
denopink merged commit eec32e3 into main Sep 1, 2026
17 of 19 checks passed
@denopink
denopink deleted the denopink/patch/auth-middleware branch September 1, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants